Fix for loading of Kohya's Musubi tuner's Flux.2 dev lora#13189
Open
christopher5106 wants to merge 1 commit intohuggingface:mainfrom
Open
Fix for loading of Kohya's Musubi tuner's Flux.2 dev lora#13189christopher5106 wants to merge 1 commit intohuggingface:mainfrom
christopher5106 wants to merge 1 commit intohuggingface:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added support for Kohya's Flux.2 loras to the PR as well.
Reproducer code is:
FLUX.2 Dev
FLUX.2 Klein
Without the fix, I previously got:
No LoRA keys associated to Flux2Transformer2DModel found with the prefix='transformer'. This is safe to ignore if LoRA state dict didn't originally have any Flux2Transformer2DModel related params. You can also try specifyingprefix=Noneto resolve the warning. Otherwise, open an issue if you think it's unexpected: https://github.com/huggingface/diffusers/issues/newWith this PR, on-the-fly conversion now works for Flux.2-dev loras also.
In this implementation, I preserved the logic of
_convert_kohya_flux_lora_to_diffusers(), with little differences: first I infer the max number of blocks from the state dict keys, second, I had to fix loras keys for the new modulesFlux2FeedForwardandFlux2ParallelSelfAttnProcessor.